make queue/collector links unclickable to prevent XSS

pyload · Jan 24, 2023 · 46d75a3 · 46d75a3
1 parent 3eeecf5
commit 46d75a3
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/src/pyload/webui/app/themes/modern/static/css/base.css b/src/pyload/webui/app/themes/modern/static/css/base.css
@@ -289,7 +289,3 @@ fieldset[disabled] .btn {
 .modal-dialog {
     margin-top: 10px;
 }
-
-.modal-dialog {
-    margin-top: 10px;
-}
diff --git a/src/pyload/webui/app/themes/modern/templates/js/packages.js b/src/pyload/webui/app/themes/modern/templates/js/packages.js
@@ -176,7 +176,7 @@ function Package (ui, id, ele){
                 link.icon = 'glyphicon glyphicon-cloud-download';
 
             var html = "<span class='child_status'><span style='margin-right: 2px;color: #337ab7;' class='" + link.icon + "'></span></span>\n" +
-                       "<span style='font-size: 16px; font-weight: bold;'><a href='" + link.url + "'>" + link.name + "</a></span><br/>" +
+                       "<span style='font-size: 16px; font-weight: bold;'><a onclick='return false' href='" + link.url + "'>" + link.name + "</a></span><br/>" +
                        "<div class='child_secrow' style='margin-left: 21px; margin-bottom: 7px; border-radius: 4px;'>" +
                        "<span class='child_status' style='font-size: 12px; color:#555; padding-left: 5px;'>" + link.statusmsg + "</span>&nbsp;" + link.error + "&nbsp;" +
                        "<span class='child_status' style='font-size: 12px; color:#555;'>" + link.format_size + "</span>" +

diff --git a/src/pyload/webui/app/themes/pyplex/templates/js/packages.js b/src/pyload/webui/app/themes/pyplex/templates/js/packages.js
@@ -176,7 +176,7 @@ function Package (ui, id, ele){
                 link.icon = 'glyphicon glyphicon-cloud-download';
 
             var html = "<span class='child_status'><span style='margin-right: 2px;color: #f9be03;' class='" + link.icon + "'></span></span>\n" +
-                       "<span style='font-size: 16px; font-weight: bold;'><a href='" + link.url + "'>" + link.name + "</a></span><br/>" +
+                       "<span style='font-size: 16px; font-weight: bold;'><a onclick='return false' href='" + link.url + "'>" + link.name + "</a></span><br/>" +
                        "<div class='child_secrow' style='margin-left: 21px; margin-bottom: 7px; border-radius: 4px;'>" +
                        "<span class='child_status' style='font-size: 12px; color:#eee; padding-left: 5px;'>" + link.statusmsg + "</span>&nbsp;" + link.error + "&nbsp;" +
                        "<span class='child_status' style='font-size: 12px; color:#eee;'>" + link.format_size + "</span>" +