Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃棐锔忊潛 Optional evaluation for pipeline #919

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

mberr
Copy link
Member

@mberr mberr commented May 10, 2022

This PR works towards making the evaluation in the pipeline function optional.

src/pykeen/pipeline/api.py Outdated Show resolved Hide resolved
@cthoyt
Copy link
Member

cthoyt commented May 10, 2022

the pipeline has become a proper frankenstein monster at this point

@mberr
Copy link
Member Author

mberr commented May 10, 2022

the pipeline has become a proper frankenstein monster at this point

It might be worth to try to separate the resolution logic from running training / evaluation.

@mberr mberr changed the title Optional evaluation for pipeline 馃棐锔忊潛 Optional evaluation for pipeline Sep 23, 2023
@mberr mberr marked this pull request as ready for review September 23, 2023 22:24
@cthoyt
Copy link
Member

cthoyt commented Sep 24, 2023

I am still skeptical of making evaluation optional. I like that the pipeline does exactly one thing, and if you want to roll your own with different functionality, there is a tutorial at https://pykeen.readthedocs.io/en/stable/tutorial/first_steps.html#beyond-the-pipeline that makes it pretty simple

It doesn't help that this PR also has big refactoring that isn't obviously relevant to making evaluation optional

@mberr
Copy link
Member Author

mberr commented Sep 24, 2023

It doesn't help that this PR also has big refactoring that isn't obviously relevant to making evaluation optional

The handle_dataset part needed to be changed to allow validation/testing to be optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants