🌯 🌪️ Encapsulate inverse relations #752
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
What's the roadmap for this PR? I think that it's fine to keep |
cthoyt
reviewed
Jan 15, 2023
…-relations # Conflicts: # src/pykeen/datasets/ogb.py # src/pykeen/models/base.py # src/pykeen/models/nbase.py # src/pykeen/training/lcwa.py
…nto encapsulate-inverse-relations # Conflicts: # src/pykeen/training/lcwa.py
…nto encapsulate-inverse-relations
cthoyt
reviewed
Sep 24, 2023
src/pykeen/models/nbase.py
Outdated
| @@ -339,6 +339,11 @@ def __init__( | |||
| triples_factory=triples_factory, | |||
| representations=relation_representations, | |||
| representations_kwargs=relation_representations_kwargs, | |||
| # TODO: check this | |||
cthoyt
reviewed
Sep 24, 2023
| @@ -651,10 +657,13 @@ def _get_representations( | |||
| h: Optional[torch.LongTensor], | |||
| r: Optional[torch.LongTensor], | |||
| t: Optional[torch.LongTensor], | |||
| invert_relation: bool = False, # TODO: do we need this here? | |||
There was a problem hiding this comment.
I think this would be necessary if we had a separate Representation module for inverse relations 🤔
cthoyt
reviewed
Sep 24, 2023
| elif self.target == 1: | ||
| self.score_method = self.model.score_r # type: ignore | ||
| elif self.target == 2: | ||
| self.supports_slicing = self.model.can_slice_r | ||
| elif self.target == 2: # TODO: inverse relations? |
There was a problem hiding this comment.
TODO what about inverse relations?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #749
Tasks:
inverse_triplesflags fromTriplesFactoryandDatasets.Dependencies
New Structure
score_hrt(h, r, t)score_h(r, t, slice_size)score_r(h, t, slice_size)score_t(h, r, slice_size)score_hrt_extended(h, r, t, invert_relation)score_h_extended(r, t, slice_size, invert_relation)score_r_extended(h, t, slice_size, invert_relation)score_t_extended(h, r, slice_size, invert_relation)score_h):predict_hrt(h, r, t, invert_relation)predict_h(r, t, slice_size, invert_relation)predict_r(h, t, slice_size, invert_relation)predict_t(h, r, slice_size, invert_relation)score_{hrt,h,t}_inverse-> move to prediction workflows?