-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend HPO-Sampling #738
base: master
Are you sure you want to change the base?
Extend HPO-Sampling #738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost all of the existing HPO model is generally applicable to all models. I'm a bit skeptical of these additions because they're pretty specific for a small (albeit important) subset of models. Before further review, I think it's important to motivate the addition of such complexity to the existing HPO model through a series of narrative examples as well as adding reference documentation (i.e., pass CI).
I think it might be the case that this motivates creating a new HPO workflow, so do carefully write up explanations for everything here so we can consider splitting it out.
Once the remaining models from https://github.com/pykeen/pykeen/projects/1 are upgrade to |
Looking back, I'm still thinking this increases complexity too much. I'm going to close this, but if anyone wants to take a careful look again, we can re-open it. |
In this PR, we extend the HPO-sampling, so that parameters of the
entity_representation
,relation_representation
, andinteraction
modules can be sampled.