-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3️⃣🦌 Add TripleRE model #715
Draft
mberr
wants to merge
85
commits into
master
Choose a base branch
from
triple-re-model
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trigger ci
trigger ci
Complete reproduction of their code would require joint Anchor + Relation tokenization 😉 |
@migalkin BAHHH |
mberr
commented
Mar 6, 2022
trigger ci
trigger ci
trigger ci
trigger ci
I'd be in favor of merging this model without that special OGB evaluator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Implementation: https://github.com/LongYu-360/TripleRE-Add-NodePiece/blob/master/TripleRE%2BNodepiece/ogb_wikikg2/model.py
Note: this PR also renames
NodePiece
'stoken_representation_kwargs
totoken_representations_kwargs
for consistency.Tasks:
"mlp"
aggregation forNodePieceRepresentation
(moved fromNodePiece
model)GalkinPickleLoader
toGalkinPicklePrecomputedTokenizerLoader
for consistencyNodePiece
'stoken_representation_kwargs
totoken_representations_kwargs
for consistencyevaluation_factory
to sampled evaluator, if this evaluator is usedPrecomputedPoolTokenizer
pipeline
(closes Build a pipeline for evaluating with OGB #366)Dependencies:
Fixes #711