Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3️⃣🦌 Add TripleRE model #715

Draft
wants to merge 85 commits into
base: master
Choose a base branch
from
Draft

3️⃣🦌 Add TripleRE model #715

wants to merge 85 commits into from

Conversation

mberr
Copy link
Member

@mberr mberr commented Jan 7, 2022

Reference Implementation: https://github.com/LongYu-360/TripleRE-Add-NodePiece/blob/master/TripleRE%2BNodepiece/ogb_wikikg2/model.py

Note: this PR also renames NodePiece's token_representation_kwargs to token_representations_kwargs for consistency.

Tasks:

  • support choosing "mlp" aggregation for NodePieceRepresentation (moved from NodePiece model)
  • rename GalkinPickleLoader to GalkinPicklePrecomputedTokenizerLoader for consistency
  • rename NodePiece's token_representation_kwargs to token_representations_kwargs for consistency
  • pass evaluation_factory to sampled evaluator, if this evaluator is used
  • allow selection of loader for PrecomputedPoolTokenizer
  • allow loading precomputed negative samples for sampled evaluator
  • since OGB uses a fixed set of negative samples for (sampled) evaluation, there need to be different evaluator instances for validation / testing, which is currently not supported by the pipeline (closes Build a pipeline for evaluating with OGB #366)

Dependencies:

Fixes #711

@migalkin
Copy link
Member

migalkin commented Feb 1, 2022

Complete reproduction of their code would require joint Anchor + Relation tokenization 😉

@cthoyt
Copy link
Member

cthoyt commented Feb 1, 2022

@migalkin BAHHH

@cthoyt cthoyt added this to the PyKEEN v1.8.0 milestone Feb 13, 2022
@mberr mberr modified the milestones: PyKEEN v1.8.0, PyKEEN v1.9.0 Mar 16, 2022
@migalkin
Copy link
Member

I'd be in favor of merging this model without that special OGB evaluator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TripleRE Build a pipeline for evaluating with OGB
3 participants