Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encapsulate inverse relations inside Model #749

Open
mberr opened this issue Jan 25, 2022 · 0 comments · May be fixed by #752
Open

Encapsulate inverse relations inside Model #749

mberr opened this issue Jan 25, 2022 · 0 comments · May be fixed by #752
Labels
enhancement New feature or request

Comments

@mberr
Copy link
Member

mberr commented Jan 25, 2022

Is your feature request related to a problem? Please describe.
The inverse triples usage is currently somewhat inconsistent, e.g., we expected the training instances to contain inverse triples, but do require evaluation triples to not contain them.

Describe the solution you'd like
Encapsulate inverse triples logic into Model class. This also would be coherent with our description in the resource and benchmarking paper, where we explain why using inverse relations is a modelling decision rather than a simple data augmentation technique.

@mberr mberr added the enhancement New feature or request label Jan 25, 2022
@mberr mberr linked a pull request Jan 25, 2022 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant