[INF] Update mkdocstrings version to 0.19.0
#1138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #1138 +/- ##
==========================================
- Coverage 97.34% 97.31% -0.04%
==========================================
Files 77 77
Lines 3240 3240
==========================================
- Hits 3154 3153 -1
- Misses 86 87 +1 |
ericmjl
reviewed
Aug 6, 2022
ericmjl
reviewed
Aug 6, 2022
| @@ -14,6 +14,7 @@ | |||
| - [ENH] Add `names_expand` and `index_expand` parameters to `pivot_wider` for exposing missing categoricals. Issue #1108 @samukweku | |||
| - [ENH] Add fix for slicing error when selecting columns in `pivot_wider`. Issue #1134 @samukweku | |||
| - [ENH] `dropna` parameter added to `pivot_longer`. Issue #1132 @samukweku | |||
| - [INF] Update `mkdocstrings` version and to fit its new coming features. PR #1138 @Zeroto521 | |||
There was a problem hiding this comment.
Oooh, this is exciting! What new features are coming?
There was a problem hiding this comment.
Sine 0.19 mkdocstrings have to set a handler. This is a breaking changing.
But good for us, we can link to sphinx doc easily. https://mkdocstrings.github.io/usage/#cross-references-to-other-projects-inventories
|
|
ericmjl
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Please describe the changes proposed in the pull request:
Part of #1133.
When I removed this line (cfeaad7). the doc-preview ci still failed.
Due to mkdocstring which stays in a lower version.
So it is time to update it.
- name: Build docs run: | conda activate pyjanitor-dev - python -m ipykernel install --user --name pyjanitor-dev pip install -e . mkdocs buildThis PR is related to #1133 (comment).
PR Checklist
Please ensure that you have done the following:
<your_username>:dev, but rather from<your_username>:<feature-branch_name>.AUTHORS.md.CHANGELOG.mdunder the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.