hooks: Fix googleapiclient.model missing docs and improve test #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hook
googleapiclient.modelwas raising this warning when running Pyinstaller:WARNING: collect_data_files - skipping data collection for module 'googleapiclient.discovery' as it is not a package.Needing workarounds to run the api client, see googleapis/google-api-python-client#876. But this can be fixed by pointing it to the correct packagegoogleapiclient.discovery_cache.The test also received an improvement. The current test only run
from googleapiclient.discovery import buildwhich is not sufficient because the error happens when calling thebuildfunction. Calling this function doesn't require a valid API key.Github Actions