Improve reliability of facts.hardware.NetworkDevices
#1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Network device names are allowed to contain most characters, except for `:`, `/`, and whitespace. Ref: https://elixir.bootlin.com/linux/v6.8.9/source/net/core/dev.c#L1047
The previous regex was matching some IPv6 addresses. Adding a mandatory `ether ` prefix solves this. Also fixed the erroneous test cases.
Solves the following issues: - `ip`: missing IPv4 address when metric is present - both: missing IPv4 address when broadcast address is not present Additionally: - Regexes now use named groups for clarity - Minor reorganization and some type hints
Based on an Arch Linux machine. Known issue: the current state parsing behavior is rather imprecise and is not consistent between `ip a` and `ifconfig -a`. For example, the `wlp6s0` interface in the `linux_ifconfig_multiple` test case should have a state of `DOWN`, not `UNKNOWN`.
sudoBash418
force-pushed
the
netdev-improvements
branch
from
ebbf4e7
to
a1f073a
Compare
|
Fixed the |
Fizzadar
approved these changes
May 12, 2024
There was a problem hiding this comment.
This is incredible work @sudoBash418, thank you for fixing and cleaning up this one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a few issues with
NetworkDevicesnot properly parsing command output.This PR fixes those issues, and adds a couple of large test cases to match.