Fix for extra whitespace in DnfRepositories fact entries #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GH seems to be confused (as usual) and is throwing a total nonsense error for this PR only despite no changes in that area. |
|
Sure, here's an excerpt from one file: And here's another (which is parsed correctly without this change): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a clean RHEL 9.3 install,
pyinfra.facts.dnf.DnfRepositoresdoesn't work as expected because there are extra spaces appended to dictionary keys, and prepanded to values.That's because the parsing code splits on
'='but doesn't handle whitespace.Also relevant for the
3.xbranch