Add some pipx operations & facts #1039
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maisim
force-pushed
the
pipx_operations_and_facts
branch
2 times, most recently
from
08c1edc
to
892eae2
Compare
maisim
force-pushed
the
pipx_operations_and_facts
branch
from
892eae2
to
7a3afb0
Compare
Fizzadar
requested changes
Jan 27, 2024
| def requires_command(self, pipx=None): | ||
| return pipx or self.pipx_command | ||
|
|
||
| def command(self, pipx=None): |
There was a problem hiding this comment.
I think we can just always use pipx as the command, there's no case where we'd have multiple versions alongside each other I think?
| # We should always use the --force flag because | ||
| # if install it's called, that meen the version missmatch | ||
| # so we need the --force flag to get the good version installed | ||
| install_command = [pipx, "install", "--force"] |
There was a problem hiding this comment.
I think force should be a keyword argument for the operation, rather than added by default. We should be hitting the upgrade command if a package is already installed?
| if packages: | ||
| current_packages = host.get_fact(PipxPackages, pipx=pipx) | ||
|
|
||
| if current_packages is None: |
There was a problem hiding this comment.
This should never be the case, facts return a default value so can drop this check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start pipx support,
Some tests do not pass but I am not sure of the way to write them in the correct way
WIP