Changed library to require supported versions of Python #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed all python shebangs to use python3 Removed utf8 encoding line at the top of python files Removed absolute_import import from __future__ Ran black over examples to cleanup a lot of PEP8 errors and standardize formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the readme, the only supported versions of Python/PyPy are:
As such, I added this requirement in
setup.py. As it stands, you can still installimgui==2.0with Python 2. This PR fixes this issue. However, I have not tested this on PyPy. I recommend testing this before merging. I also recommend releasing this as pyimgui 2.0.1 OR pyimgui 2.0.0.post1, then yanking 2.0.0. This will prevent a user from accidentally installing pyimgui 2.0.0 on Python 2 (or other unsupported versions), but will also not break existing projects.Additionally, I changed the things @learn-more had mentioned in #311. These things include changing all shebangs to use
python3, removing allcoding: utf-8lines as these are only required for Python 2, and removingfrom __future__ import absolute_importas again, this was only required for Python 2.Lastly, I ran black on the examples to fix line length and other formatting issues. Black also has issues with a lot of other Python files in the project, but I wanted to restrict this PR. With that said, I can run black on the entire project in this or a separate PR to standardize the whole project.