-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/DLL (study) #247
base: master
Are you sure you want to change the base?
Feature/DLL (study) #247
Conversation
…o link pyimgui to an externally built version of imgui
Thank you for looking into this. In terms of ideas on how to go about this moving forward, I would suggest following the pattern that is used by pySDL2. The python wrapper around the DLL is a python pure project, which makes maintaining it and deploying it very simple (you don't need to build wheels or anything). |
btw, it is not recommended to use Dear ImGui as dll:
|
Yes I know; the problem is that it seems to be the cleanest way to share the implementation between different python modules (core, internals, etc), avoiding duplicates, as it is the case now. Moreover, it would allow to easily communicate between python and other languages, such as C++, in which core functionalities of an user app may be implemented. I may have overlooked some options; any suggestion is welcome. |
Any progress on this? I'm trying to accomplish a similar task. |
Many thanks for all the hard work you have done to this end updating PyImGui. Regarding Feature/DLL there are imho two potentially relevant or at least interesting repositories: https://github.com/harskish/pyplotgui) from @harskish updating to previous work from @hinxx to PyImGui 2.0 dev version Maybe harskish could update his extensions to PyImGUI 2.0 final and create a pull request for taking the study of the DLL feature further. For comparison (potential performance benchmarks), there is also an alternative Python integration from harskish in this repository: https://github.com/harskish/imviz Of cause, there are other interesting extensions like imnode and imgui-knobs, for example. Peter |
Hey, thanks for reaching out. No, I did not manage to progress on this unfortunately. And I probably won't have time to work on it this summer. I agree with what @Inventor-Mentor is saying, it may be a good place to continue working on the feature. |
Starting the DLL feature as discussed in other PRs and issues.
Starting from @pvallet's proposal: #229, thanks!
The idea is to check whether it is doable in the long run to not compile DearImGui directly inside pyimgui but as an independent DLL. This would solve the code duplication problem of submodules such as
internal
and should offer the possibility to develop addons such aspyimplot
orpyimnode
without having to bake them insidepyimgui
.Objectives of this branch are to
pyimgui
that compile DearImGui as an external DLL and uses it.Big thanks to @Inventor-Mentor for his insight and thoughts on that matter. See his post for more information: #244 (comment)