Fix uniforms in pyglet.graphics.shader #1103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug in Pyglet where the
Uniform
object doesn't have the reference to theShaderProgram
it belongs to.This causes problems when we try to write a numpy array to the uniform object.
When we try to assign to a uniform from Numpy array, it throws an error without this patch:
Where
thresholds
is defined like this in the shader source code: