Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a fix for channel.fadeout using Mix_HaltChannel #4134

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

romgird2
Copy link
Contributor

Hello,

In mixer_tests.py, we remarked that the tests test_fadeout_with_zero_time and test_fadeout_with_negative_time failed.

Investigating on the issue, we saw that the C function chan_fadeout in mixer.c does not check for <= 0 argument.

Thus, we propose to add a if statement in chan_fadeout to check for this condition and call Mix_HaltChannel in this case to stop the sound, as requested by the documentation.

Thanks for your consideration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants