Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle only the required pygame icon files #2854

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

ankith26
Copy link
Member

fixes #2780

@ankith26 ankith26 requested a review from a team as a code owner May 14, 2024 18:21
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Starbuck5
Copy link
Member

Does this also need changes in setup.py?

@ankith26
Copy link
Member Author

I could do the corresponding changes in setup.py, but my idea is: now that we are moving away from it, we don't need to port any enhancements to it - just porting bugfixes will do

Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then, this should be nice!

@Starbuck5 Starbuck5 added this to the 2.5.0 milestone May 21, 2024
@Starbuck5 Starbuck5 merged commit 622320c into main May 21, 2024
36 checks passed
@Starbuck5 Starbuck5 deleted the ankith26-icon-strip branch May 21, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude mac specific assets from other builds
3 participants