Deprecate setup.py docs, make docs in meson build
#2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
force-pushed
the
ankith26-use-makeref
branch
from
818bd8a
to
014bd6b
Compare
ankith26
changed the title
setup.py docs, suggest and use replacement buildconfig/makeref.py
ankith26
force-pushed
the
ankith26-use-makeref
branch
from
014bd6b
to
58d0120
Compare
ankith26
changed the title
setup.py docs, suggest and use replacement buildconfig/makeref.pysetup.py docs, make docs in meson build
|
Should we take the opportunity to rename 'makeref.py' if it is going to be user facing? That is kind of a terrible name for a 'build the docs' script file. |
|
How about just renaming it to just UPDATE: have renamed it to |
ankith26
force-pushed
the
ankith26-use-makeref
branch
from
ab0dd63
to
c7878b1
Compare
zoldalma999
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another small step in our move away from
setup.py.python setup.py docsinternally executespython buildconfig/makeref.py, so this PR makes the straightforward replacement.Also, another change that this PR makes is that it adds an invocation of above into the meson build itself. This makes the build process further streamlined under one command.
Should also help fix the fails in #2850