-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mixer docs #2738
Update mixer docs #2738
Conversation
Clarify mixer docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I have left a minor review suggestion at one place, the rest of the changes LGTM
I disagree that the "0.0 -1.0" range needs clarification for volume. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sure, it makes the wording slightly more verbose, but it reduces the room for any confusion I guess. Therefore I think this PR is a merge-able state now.
Thanks for contributing to pygame-ce! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK 👍
I think mixer module docs need some clarification.
A value from 0 to the value of get_num_channels()
is for [0-num_channels), whilethe value argument is between 0.0 and 1.0
,volume in the range of 0.0 to 1.0 (inclusive)
anda value from 0.0 to 1.0 representing the volume
mean [0.0-1.0].Should it be "from x to y (inclusive/exclusive)" everywhere?