Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude mac specific assets from other builds #2780

Closed
Starbuck5 opened this issue Mar 29, 2024 · 1 comment · Fixed by #2854
Closed

Exclude mac specific assets from other builds #2780

Starbuck5 opened this issue Mar 29, 2024 · 1 comment · Fixed by #2854
Labels
buildconfig

Comments

@Starbuck5
Copy link
Member

Starbuck5 commented Mar 29, 2024 •
edited

This should probably happen after #2557, let that get resolved first.

We have mac specific assets:
src_py/pygame_icon_mac.bmp
src_py/pygame_icon.icns

Combined, they are 500kb.

If we can remove that from the 40 non-mac builds we do, we can reduce the size of a release by 20mb.
Edit: forgot about whl compression. They are 286 kb combined compressed, so the 40 builds would save a total 11.4 mb. That's almost as much as getting rid of a full wheel.

On another note, what are pygame_icon.icns and pygame.ico even doing?
@ankith26
Copy link
Member

I also don't see how pygame.ico and pygame_icon.icns are being used, so we can probably remove them and then test if pygame applications show the icon as they should?

@ankith26 ankith26 mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
buildconfig
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bundle only the required pygame icon files pygame-community/pygame-ce
2 participants
@Starbuck5 @ankith26