Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G-retriever (GNN+LLM) example w/ demo & GNN+LLM integration #9167

Open
wants to merge 556 commits into
base: master
Choose a base branch
from

Conversation

puririshi98
Copy link
Contributor

@puririshi98 puririshi98 commented Apr 8, 2024

repro:
Latest NVIDIA PyG container
+
git config --global credential.helper store; huggingface-cli login; cd /opt/pyg; pip uninstall -y torch-geometric; rm -rf pytorch_geometric; git clone -b gnn-llm-model-integration https://github.com/pyg-team/pytorch_geometric.git; cd /opt/pyg/pytorch_geometric; pip install .; pip install peft datasets transformers pcst_fast sentencepiece; python3 examples/llm_plus_gnn/g_retriever.py

old PR: #9154

note: pure cpu is 220x slower than pure GPU using a single Grace Hopper

info:
tried gemma, performs worse in all train/val/test metrics. most likely needs some tuning, will leave this as future work as part of the community sprint to try many LLM and GNN combos and tune them. Therefore keeping the default llama2

@puririshi98 puririshi98 changed the title G-retriever (GNN+LLM) example w/ demo, w/ GNN+LLM integration G-retriever (GNN+LLM) example w/ demo & GNN+LLM integration Apr 8, 2024
@puririshi98 puririshi98 self-assigned this Apr 8, 2024
@puririshi98
Copy link
Contributor Author

@Kh4L reviews welcome

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 16.10738% with 250 lines in your changes are missing coverage. Please review.

Project coverage is 87.21%. Comparing base (61c47ee) to head (48be260).
Report is 10 commits behind head on master.

Current head 48be260 differs from pull request most recent head 6e0151f

Please upload reports for the commit 6e0151f to get more accurate results.

Files Patch % Lines
torch_geometric/nn/text/llm.py 16.41% 112 Missing ⚠️
torch_geometric/nn/models/g_retriever.py 11.66% 106 Missing ⚠️
...eometric/nn/text/sentence_transformer_embedding.py 20.00% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9167      +/-   ##
==========================================
- Coverage   87.33%   87.21%   -0.13%     
==========================================
  Files         460      477      +17     
  Lines       30385    31051     +666     
==========================================
+ Hits        26536    27080     +544     
- Misses       3849     3971     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puririshi98 puririshi98 changed the title G-retriever (GNN+LLM) example w/ demo & GNN+LLM integration Draft: G-retriever (GNN+LLM) example w/ demo & GNN+LLM integration Apr 10, 2024
@puririshi98 puririshi98 changed the title Draft: G-retriever (GNN+LLM) example w/ demo & GNN+LLM integration G-retriever (GNN+LLM) example w/ demo & GNN+LLM integration Apr 10, 2024
@puririshi98 puririshi98 changed the title G-retriever (GNN+LLM) example w/ demo & GNN+LLM integration Draft: G-retriever (GNN+LLM) example w/ demo & GNN+LLM integration Apr 10, 2024
@puririshi98 puririshi98 changed the title Draft: G-retriever (GNN+LLM) example w/ demo & GNN+LLM integration G-retriever (GNN+LLM) example w/ demo & GNN+LLM integration Apr 10, 2024
@puririshi98 puririshi98 changed the title G-retriever (GNN+LLM) example w/ demo & GNN+LLM integration Draft: G-retriever (GNN+LLM) example w/ demo & GNN+LLM integration Apr 10, 2024
puririshi98 and others added 29 commits May 23, 2024 14:30
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 16.10738% with 250 lines in your changes are missing coverage. Please review.

Project coverage is 87.21%. Comparing base (61c47ee) to head (48be260).
Report is 10 commits behind head on master.

Current head 48be260 differs from pull request most recent head 6e0151f

Please upload reports for the commit 6e0151f to get more accurate results.

Files Patch % Lines
torch_geometric/nn/text/llm.py 16.41% 112 Missing ⚠️
torch_geometric/nn/models/g_retriever.py 11.66% 106 Missing ⚠️
...eometric/nn/text/sentence_transformer_embedding.py 20.00% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9167      +/-   ##
==========================================
- Coverage   87.33%   87.21%   -0.13%     
==========================================
  Files         460      477      +17     
  Lines       30385    31051     +666     
==========================================
+ Hits        26536    27080     +544     
- Misses       3849     3971     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants