Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added log_softmax to utils with tests #8909

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

elilaird
Copy link

Add log_softmax for Sparse Tensors in torch_geometric

  • Implements log_softmax function for numerical stability in GNNs
  • Includes comprehensive tests for correctness and backward compatibility
  • Benchmarks performance against PyTorch's built-in log_softmax
  • Detailed documentation

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.59%. Comparing base (e2a69a1) to head (94c2a74).
Report is 3 commits behind head on master.

❗ Current head 94c2a74 differs from pull request most recent head 58c6be2. Consider uploading reports for the commit 58c6be2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8909      +/-   ##
==========================================
+ Coverage   82.68%   89.59%   +6.91%     
==========================================
  Files         470      471       +1     
  Lines       30187    30196       +9     
==========================================
+ Hits        24960    27054    +2094     
+ Misses       5227     3142    -2085     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elilaird
Copy link
Author

elilaird commented Mar 1, 2024

Ready for merge/review 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants