Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added modifed version of PMLP with edge attributes #8898

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

chaous
Copy link
Contributor

@chaous chaous commented Feb 12, 2024

No description provided.

@451578928
Copy link

451578928 commented Feb 12, 2024 via email

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: Patch coverage is 22.80702% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 89.13%. Comparing base (f4b5e50) to head (e811146).

Files Patch % Lines
torch_geometric/nn/models/pmlp.py 22.80% 44 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8898      +/-   ##
==========================================
- Coverage   89.26%   89.13%   -0.13%     
==========================================
  Files         468      468              
  Lines       30033    30089      +56     
==========================================
+ Hits        26808    26819      +11     
- Misses       3225     3270      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusty1s
Copy link
Member

rusty1s commented Feb 12, 2024

Thanks. Is this based on a specific follow up paper of PMLP? I am not totally sure how and why PMLP should work with edge features being present. Can you clarify?

@chaous
Copy link
Contributor Author

chaous commented Feb 12, 2024

I used this architecture for my project and adding edge features increased accuracy of PMLP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants