New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for torch.compile
in RGCNConv
#8783
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8783 +/- ##
=======================================
Coverage 89.25% 89.26%
=======================================
Files 467 467
Lines 29919 29928 +9
=======================================
+ Hits 26705 26714 +9
Misses 3214 3214 ☔ View full report in Codecov by Sentry. |
@allow_in_graph | ||
def disable_use_segment_matmul() -> None: | ||
torch_geometric.backend.use_segment_matmul = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't we need to reset it somewhere?
if is_compiling(): | ||
disable_use_segment_matmul() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for asking so many questions. What was the reason for the graph break in the first place? Computing the heuristic? Can't we just do
if is_compiling():
use_segment_matmul = False
else:
use_segment_matmul = torch_geometric.backend.use_segment_matmul
if use_segment_matmul is None:
pass
etc
I'll keep this PR on hold, as it makes more sense to first update the segment matmul heuristic (what @puririshi98 did in #8615). I see two graph breaks in the test case due to:
|
Fixes #8467.