Upgrade visualize_graph for explain module #8743
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
(I will add this to another PR, but not here)
Sutongtong233
requested review from
wsad1,
RexYing,
RBendias,
dufourc1 and
rusty1s
as code owners
for more information, see https://pre-commit.ci
wsad1
reviewed
Feb 9, 2024
| @@ -233,7 +233,7 @@ def visualize_feature_importance( | |||
| return _visualize_score(score, feat_labels, path, top_k) | |||
|
|
|||
| def visualize_graph(self, path: Optional[str] = None, | |||
| backend: Optional[str] = None): | |||
| backend: Optional[str] = None, **kwargs): | |||
There was a problem hiding this comment.
Suggested change
| backend: Optional[str] = None, **kwargs): | |
| backend: Optional[str] = None, | |
| nodel_label: Optional[Tensor] = None, | |
| colors_dict: Optional[Dict[int, str] = None, | |
| target_idx: Optional[int]=None): |
Lets add the new arguments as optional arguemnts and add documentation for them. That way the end user is aware of the options available to them.
| if target_node != None: | ||
| for i, node_id in enumerate(list(g.nodes)): | ||
| if node_id == target_node: | ||
| print("kylin") |
| @@ -127,10 +134,26 @@ def _visualize_graph_via_networkx( | |||
| ), | |||
| ) | |||
|
|
|||
| node_color = ['white'] * len(g.nodes) | |||
| if node_label != None: | |||
There was a problem hiding this comment.
So if node_label is None won't all nodes be white?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For current
visualize_graph, the node colors are default 'white', which is not as intuitive as in GNNExplainer: target node is red, different node class with different node color.We add three optional params:
We add lines at two examples
examples/explain/gnn_explainer.pyandexamples/explain/gnn_explainer_ba_shapes.pyI am not sure about how to add optional params. Currently we add them at **kwargs.