Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: allow None in sh_order setter #596

Merged
merged 1 commit into from May 3, 2024
Merged

hotfix: allow None in sh_order setter #596

merged 1 commit into from May 3, 2024

Conversation

ahms5
Copy link
Member

@ahms5 ahms5 commented Apr 26, 2024 •
edited

Changes proposed in this pull request:

  • coords.sh_order = None was not working

@ahms5 ahms5 self-assigned this Apr 26, 2024
@ahms5 ahms5 added bug For bugs not on the master branch coordinates 0.6.6 labels Apr 26, 2024
@ahms5 ahms5 changed the title fix sh_order setter hotfix: allow None in sh_order setter Apr 26, 2024
@mberz mberz merged commit fdf5fb1 into main May 3, 2024
11 checks passed
@ahms5 ahms5 mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mberz mberz mberz approved these changes

@pingelit pingelit pingelit approved these changes

@f-brinkmann f-brinkmann f-brinkmann approved these changes

@sikersten sikersten Awaiting requested review from sikersten

Assignees

@ahms5 ahms5

Labels
0.6.6 bug For bugs not on the master branch coordinates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ahms5 @mberz @pingelit @f-brinkmann