Remove phase for FFT normalizations 'power' and 'psd' #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2024 11:59
sikersten
added
enhancement
sikersten
requested review from
mberz,
pingelit,
f-brinkmann,
ahms5 and
hoyer-a
ahms5
approved these changes
Mar 22, 2024
pingelit
approved these changes
Apr 5, 2024
f-brinkmann
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) are closed by this pull request?
Closes #553: Contrary to their definitions, FFT normalizations 'power' and 'psd' retained the phase of the signal. I think its a leftover from before the 'signal.freq_raw' property was introduced in 0.4.0 (PR #274), when retaining the phase was required to correctly calculate the inverse.
Changes proposed in this pull request:
spec*np.abs(spec)tonp.abs(spec)**2