New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop complex signals #504
Draft
f-brinkmann
wants to merge
170
commits into
develop
Choose a base branch
from
develop_complex_signals
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow time data to be complex valued, chose FFT accordinlgy, and wrap fft and ifft for two-sided Fourier transform
Change parameter order in TimeSignal and Signal class Add doc-string to TimeSignal and Signal Introduce complex flag in Signal and TimeSignal and remove n_sample == n_bins check Shift complex-check to TimeSignal remove complex setter in TimeSignal (to be discussed)
add small check that complex is a bool adapt docstrings use class property instead of _complex change _fft to sfft
prohibit "rms" normalization for complex time signals
Update data docstring for signals Put num samples check to private signal method introduce complex flag for fft._n_bins method
Co-authored-by: Fabian Brinkmann <fabian.brinkmann@mailbox.org>
Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
fft for two-sided spectra are returns the spectra for ascending frequencies now Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
according to changes in fft, apply circshift before calculating inverse fft for two-sided spectra Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
Raise value error for complex Signals for modes: 'log_magnitude_zerophase', 'magnitude_zerophase', 'magnitude_phase', 'power'
Complex group delay
Test complex concatenate
Complex power energy rms
…gals implement tests
implement more detailed value error messages
Complex normalization
Bugfix set complex freq
Complex deconvolution
…omplex Test find impulse response delay complex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) are closed by this pull request?
Closes #384
Changes proposed in this pull request:
This is a branch for collecting approved pull requests related to #384. It will be merged once all the tasks are done