Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop complex signals #504

Draft
wants to merge 170 commits into
base: develop
Choose a base branch
from
Draft

Develop complex signals #504

wants to merge 170 commits into from

Conversation

f-brinkmann
Copy link
Member

Which issue(s) are closed by this pull request?

Closes #384

Changes proposed in this pull request:

This is a branch for collecting approved pull requests related to #384. It will be merged once all the tasks are done

tluebeck and others added 30 commits November 22, 2022 14:21
allow time data to be complex valued, chose FFT accordinlgy, and wrap fft and ifft for two-sided Fourier transform
Change parameter order in TimeSignal and Signal class
Add doc-string to TimeSignal and Signal
Introduce complex flag in Signal and TimeSignal and remove n_sample == n_bins check
Shift complex-check to TimeSignal
remove complex setter in TimeSignal (to be discussed)
add small check that complex is a bool
adapt docstrings
use class property instead of _complex
change _fft to sfft
prohibit "rms" normalization for complex time signals
Update data docstring for signals
Put num samples check to private signal method
introduce complex flag for fft._n_bins method
Co-authored-by: Fabian Brinkmann <fabian.brinkmann@mailbox.org>
Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
fft for two-sided spectra are returns the spectra for ascending frequencies now

Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
according to changes in fft, apply circshift before calculating inverse fft for two-sided spectra

Co-authored-by: Marco Berzborn <mberz@users.noreply.github.com>
Raise value error for complex Signals for modes: 'log_magnitude_zerophase', 'magnitude_zerophase', 'magnitude_phase', 'power'
tluebeck and others added 30 commits March 29, 2024 13:08
implement more detailed value error messages
…omplex

Test find impulse response delay complex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audio Classes pyfar.classes.audio complex-signal feature For requesting new features
Projects
Code Backlog
In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants