adapt convolution for complex singals and implement testing #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-brinkmann
requested changes
May 3, 2023
pyfar/dsp/dsp.py
Outdated
Comment on lines
1659
to
1662
| if res.dtype.kind == 'c': | ||
| is_result_complex = True | ||
| else: | ||
| is_result_complex = False |
There was a problem hiding this comment.
Could be shortened
Suggested change
| if res.dtype.kind == 'c': | |
| is_result_complex = True | |
| else: | |
| is_result_complex = False | |
| complex = True if res.dtype.kind == 'c' else False |
add docstrings to tests shorten query for complex convolution results
f-brinkmann
approved these changes
May 11, 2023
ahms5
reviewed
Jun 26, 2023
pyfar/dsp/dsp.py
Outdated
| @@ -1656,8 +1656,11 @@ def convolve(signal1, signal2, mode='full', method='overlap_add'): | |||
| res[..., :n_min-1] += res[..., -n_min+1:] | |||
| res = res[..., :n_max] | |||
|
|
|||
| complex = True if res.dtype.kind == 'c' else False | |||
There was a problem hiding this comment.
why not to take it from signal1 and signal2? and check if res.dtype.kind make sence?
Suggested change
| complex = True if res.dtype.kind == 'c' else False | |
| complex = signal1.complex | signal2.complex |
tluebeck
changed the base branch from
complex_time_signals
to
develop_complex_signals
ahms5
reviewed
Dec 11, 2023
| ('full', np.array([[1, -0.5, 0.1, -0.35, -0.05, 0.01]], dtype='complex')), | ||
| ('cut', np.array([[1, -0.5, 0.1, -0.35]], dtype='complex')), | ||
| ('cyclic', np.array([[0.95, -0.49, 0.1, -0.35]], dtype='complex'))]) | ||
| def test_convolve_mode_and_method_complex(method, mode, desired): |
There was a problem hiding this comment.
How about testing complex signals and also one complex and one real signal.
implement convolution test for one complex and one real valued signal
pingelit
approved these changes
Dec 17, 2023
ahms5
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adapt convolution and implement tests