Update dsp.average for complex signals #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 28, 2023 09:22
Raise value error for complex Signals for modes: 'log_magnitude_zerophase', 'magnitude_zerophase', 'magnitude_phase', 'power'
f-brinkmann
changed the title
|
What is the idea behind not having these modes for complex signals - wouldn't the operations be possible in general? |
f-brinkmann
approved these changes
May 11, 2023
ahms5
approved these changes
Jun 26, 2023
ahms5
reviewed
Jun 26, 2023
| 'power',)): | ||
|
|
||
| raise ValueError(( | ||
| f"mode '{mode}' is not defined for complex signals.")) |
There was a problem hiding this comment.
what does not defined mean? according to the description above it should be defined, or does it mean it's not implemented?
There was a problem hiding this comment.
If I remember our discussion correctly, we did not check in depth if there is a usefull definition and leave it up to people who need that to implement in case there is one.
tluebeck
changed the base branch from
complex_time_signals
to
develop_complex_signals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise value error for complex Signals for modes: 'log_magnitude_zerophase', 'magnitude_zerophase', 'magnitude_phase', 'power'