Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retaining the phase for FFT normalizations 'power' and 'psd' is obsolete #553

Open
sikersten opened this issue Mar 5, 2024 · 0 comments
Labels
dsp fft signals Module pyfar.signals

Comments

@sikersten
Copy link
Member

General

  • pyfar version: 0.6.4

Description

pyfar.dsp.normalization retaines the phase information for the normalizations 'power' and 'psd', though there are regularly defined as real-valued only.
I think this is a leftover from before the signal.freq_raw property was introduced in 0.4.0 (PR #274), which stores the spectrum without normalization (incl. phase). We should consider removing phase information to have coherent definitions.

What I Did

import pyfar as pf
import numpy as np

signal = pf.signals.noise(44100)
signal.fft_norm = 'psd'
pf.plot.freq_phase(signal)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dsp fft signals Module pyfar.signals
Projects
None yet
Development

No branches or pull requests

1 participant