Github Action: if PR with tag 'cookiecutter' is merged, it will create an issue in cookiecutter-pypackage #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingelit
requested changes
Apr 29, 2024
| types: [ labeled ] | ||
| name: Create issue if pr gets a cookiecutter label | ||
| jobs: | ||
| stuff: |
There was a problem hiding this comment.
Could you give the job a reasonable name? Like, create_issue?
| contents: read | ||
| issues: write | ||
| name: create issue | ||
| environment: test |
There was a problem hiding this comment.
Do we need this environment? Or is that referencing the circleCI environment?
|
thank you for reviewing @pingelit. Your comments are about the content which are already reviewed in pyfar/pyfar#586. If you want to improve it we need to make an PR in pyfar first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) are closed by this pull request?
Closes #18 and #25
will not fail if pyfar/pyfar#607 is merged