Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG+1] Deprecate DeferredDataElement #683

Merged
merged 2 commits into from
Jul 19, 2018

Conversation

scaramallion
Copy link
Member

Reference Issue

Closes #291

What does this implement/fix? Explain your changes.

Deprecates DeferredDataElement for removal in v1.3

@scaramallion scaramallion changed the title [WIP] Deprecated DeferredDataElement [WIP] Deprecate DeferredDataElement Jul 19, 2018
@@ -4,6 +4,9 @@ Version 1.2.0
Changelog
---------

* ``DeferredDataElement`` class deprecated and will be removed in v1.3
(:pull request:`291`)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be issue instead of pull request.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@scaramallion scaramallion changed the title [WIP] Deprecate DeferredDataElement [MRG] Deprecate DeferredDataElement Jul 19, 2018
@mrbean-bremen mrbean-bremen changed the title [MRG] Deprecate DeferredDataElement [MRG+1] Deprecate DeferredDataElement Jul 19, 2018
@darcymason
Copy link
Member

Looks good. Reminder that this requires #139 to be in place for v1.2 (already labeled as such).

@darcymason darcymason merged commit 20aa7ac into pydicom:master Jul 19, 2018
@scaramallion scaramallion deleted the dep-deferred branch July 19, 2018 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeferredDataElement deprecation
3 participants