Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Third attempt to fix codecov uploads #2055

Merged
merged 1 commit into from
May 9, 2024

Conversation

scaramallion
Copy link
Member

🤦‍♂️

@scaramallion scaramallion changed the title Third attempt to fix codecov uploads [MRG] Third attempt to fix codecov uploads May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (4bc3d1f) to head (65b1b76).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2055   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files          76       76           
  Lines       12326    12326           
=======================================
  Hits        12106    12106           
  Misses        220      220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely missed that...

@scaramallion scaramallion merged commit 31be9fb into pydicom:main May 9, 2024
10 checks passed
@scaramallion scaramallion deleted the house-cc-3 branch May 9, 2024 22:40
@scaramallion
Copy link
Member Author

scaramallion commented May 9, 2024

OK, working now. Although there are a couple of intermittent test failures that aren't being caught which needs fixing (both the test failures, and for the test failures not causing the workflow to fail).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants