Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] Apply ruff/flake8-implicit-str-concat rule ISC001 #2049

Merged
merged 3 commits into from May 6, 2024
Merged

[MRG] Apply ruff/flake8-implicit-str-concat rule ISC001 #2049

merged 3 commits into from May 6, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented May 6, 2024 •
edited

Describe the changes

https://docs.astral.sh/ruff/rules/single-line-implicit-string-concatenation/

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Code typed and mypy shows no errors
  • Documentation updated (if relevant)
    • No warnings during build
    • Preview link (CircleCI -> Artifacts -> doc/_build/html/index.html)
  • Unit tests passing and overall coverage the same or better

@scaramallion scaramallion merged commit 3118444 into pydicom:main May 6, 2024
7 checks passed
@scaramallion
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scaramallion scaramallion scaramallion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DimitriPapadopoulos @scaramallion