Prep2.4b

[darcymason]

No description provided.

[codecov]

Codecov Report

Merging #1807 (d00ec87) into master (397f32e) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1807      +/-   ##
==========================================
+ Coverage   97.41%   97.43%   +0.01%     
==========================================
  Files          66       66              
  Lines       10839    10839              
==========================================
+ Hits        10559    10561       +2     
+ Misses        280      278       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[darcymason]

Sorry, @mrbean-bremen, we may have to go through a number of approval cycles with fixes before this gets finalized. Still doesn't appear on Actions as a PR...

Or, ... I could temporarily make the main branch merges not require an approval. Perhaps I will dor that if we go a couple more times this way.

[mrbean-bremen]

Ah, right!

[mrbean-bremen]

BTW, you should also be able to trigger the workflow from the branch, without merging it first
...or not, I don't see the respective button there.

[darcymason]

So I pushed directly to master, and ran the workflow -- it appeared on live PyPI, not the test PyPI. Argh... somehow the environment url did not get picked up and it fell to defaults. Frustrating because I modeled this on the script shown on the pypa page, quite closely, I thought.

Problem now is I still want to create 2.4.X branch and create a project release on the github UI (and tag the commit), which will trigger the workflow again, and it will fail the pypi upload because the version already exists. I guess that is okay. What do you think, try that, accept the release is done, and try to fix this for next release?

[mrbean-bremen]

What do you think, try that, accept the release is done, and try to fix this for next release?

Yes, not a big deal, if the uploaded version is ok.

So far, I had only the opposite problem - the upload failed after I made a GH release, which was easy to fix by deleting the release and the tag, fixing the upload and retrying. And while a version can be yanked from PyPi, I think it cannot be re-uploaded after that, so we are stuck with that.

I case the upload is indeed broken for some reason, you could still yank it from PyPi and make a new patch release (I did this once).

[darcymason]

I case the upload is indeed broken for some reason, you could still yank it from PyPi and make a new patch release (I did this once).

Yes, I think I've had to do that before at some point.

Thanks for your help and comments.

BTW, normal required PR/approval is set back again.

[mrbean-bremen]

BTW, normal required PR/approval is set back again.

I didn't even notice that it was off 😀