[MRG] Iterate through the value attribute #1482
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1482 +/- ##
=======================================
Coverage 97.42% 97.42%
=======================================
Files 66 66
Lines 10182 10182
=======================================
Hits 9920 9920
Misses 262 262
Continue to review full report at Codecov.
|
| @@ -329,7 +329,7 @@ class Dataset: | |||
| >>> def recurse(ds): | |||
| ... for elem in ds: | |||
| ... if elem.VR == 'SQ': | |||
| ... [recurse(item) for item in elem] | |||
| ... [recurse(item) for item in elem.value] | |||
There was a problem hiding this comment.
I think this is not needed - shall work without the change, as the iterator will access the value automatically.
There was a problem hiding this comment.
Ahh cool, okay didn't know that. Cheers :)
There was a problem hiding this comment.
I did suggest we remove that, though. I'm not a fan of DataElement itself being iterable
There was a problem hiding this comment.
I've just now seen that @scaramallion's recommendation has made the v3.0 checklist:
Potentially it's worth making the change to the docs now so that new code that people write based on the docs will be forwards compatible for this recursive iteration pattern?
There was a problem hiding this comment.
I agree that this syntax should be encouraged.
Update doc string to use `elem.value`.
Adjusting docs