New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFATORAÇÃO] SOLID e Clean Code em scheduler.py #31
Open
RCristyan
wants to merge
150
commits into
pydemic:master
Choose a base branch
from
GCES-Pydemic:REFACTOR_SOLID_CLEAN_CODE_scheduler
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[REFATORAÇÃO] SOLID e Clean Code em scheduler.py #31
RCristyan
wants to merge
150
commits into
pydemic:master
from
GCES-Pydemic:REFACTOR_SOLID_CLEAN_CODE_scheduler
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lyra <guilyra12@gmail.com>
#13 - Make Pydemic UI compatible with latest version of streamlit
Update issue templates
Update issue templates
Merge changes from upstream into master of fork
hotfixing streamlit version
Update README
Initial HTML Report Class
…nto REFACTOR_SOLID_CLEAN_CODE_api_explorer_class
…nto REFACTOR_SOLID_CLEAN_CODE_scheduler
RCristyan
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Nov 24, 2020
…cache Refactoring cache to use Class [single-responsibiliy principle]
…calc_class applying solid principles to calc_class.py
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
========================================
Coverage ? 3.97%
========================================
Files ? 76
Lines ? 4548
Branches ? 472
========================================
Hits ? 181
Misses ? 4366
Partials ? 1 Continue to review full report at Codecov.
|
…i_explorer_class Refactor solid clean code api explorer class
Refactor scenarios apps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O arquivo scheduler foi refatorado para aplicação de alguns princípios de Clean Code e SOLID. Resolve esta issue.
Exemplo de Single Responsability Principle:
Em vez de calcular as formas diferentes de se agendar uma tarefa no loop principal, foram criados métodos específicos para isso. Existem métodos públicos para agendar tarefas diariamente, semanalmente e mensalmente, e existem métodos privados (cujos nomes começam com dois underscore) que são chamados internalmente pela classe.
Exemplo de composição de métodos:
No loop principal da classe Scheduler, são chamados métodos especializados em cada tipo de agendamento.
A aplicação deste princípio de Clean Code facilita a manutenibilidade do código.
Exemplo de renomeação de variáveis:
O Clean Code tem um princípio que diz que nomes de variáveis devem expressar suas finalidades, por isso algumas variáveis foram renomeadas.
Houveram também outras modificações menores no código, porém as funcionalidades originais do código não foram afetadas.