Avoid infinite recursion in Resource.__getattr__ #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Otherwise the `self.raw` access within the except handler below comes back through and if the originally requested item isn't actually in self.raw then it loops forever.
adehad
force-pushed
the
avoid-infinite-recursion
branch
from
2fe4691
to
543f87d
Compare
|
@sparrowt would be great if you can add that test case into: https://github.com/pycontribs/jira/blob/main/tests/test_client.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the
self.rawaccess within the except handler below comes back through and if the originally requested item isn't actually in self.raw then it loops forever.Fixes: #1721
I haven't added a test as it seems pretty niche but there is a repro test case on the issue linked above which we can incorporate if desired?