Add option to persist cookies #1720
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change `auth` param from tuple to dict to support optional `cookie_jar` param. * Add option to provide callable for lazy password fetching.
dosy4ev
force-pushed
the
persist_cookie
branch
from
e0bac5f
to
eb3a752
Compare
|
fixes #883 |
adehad
reviewed
Dec 21, 2023
Comment on lines
-471
to
+498
| auth (Optional[Tuple[str,str]]): Set a cookie auth token if this is required. | ||
|
|
||
| auth (Optional[Dict[str, Any]]): A dict of properties for Cookei authentication. | ||
| The following properties are available: | ||
|
|
||
| * username (srt) -- username | ||
| * password (str | Callable[[], str]) -- password or function for lazy receiving password | ||
| * cookie_jar (Optional[srt]) -- file path for persisting cookies | ||
|
|
There was a problem hiding this comment.
It would be better if we can support both tuple and dict, with a deprecation warning for the tuple. As we need to consider all users
adehad
requested changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
authparam from tuple to dict to support optionalcookie_jarparam.