Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use 'standard' file extensions for output files #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use 'standard' file extensions for output files #139

wants to merge 1 commit into from

Conversation

duncanmmacleod
Copy link
Member

Reference Issue

Fixes #134

What does this pull request implement/fix? Explain your changes.

This PR patches the relevant class instance methods to use the following file extensions, rather than just .submit for everything:

  • use .dag for dag files
  • use .sub for submit files

Any other comments?

@duncanmmacleod
Copy link
Member Author

@GregoryAshton, can you comment on how disruptive this change would be for, e.g, the Bilby (pipe) workflows? Do other parts of the workflow presume hardcoded .submit file extensions?

@GregoryAshton
Copy link
Contributor

@duncanmmacleod from a brief check, I'm fairly certain there is only a printed statement on how to submit the file which would need to be changed.

@duncanmmacleod duncanmmacleod added this to the PyCondor 0.7.0 milestone Jun 27, 2022
@jodergrosse
Copy link
Collaborator

I did use a similar patch. Didn't have any issues with it and would agree, that it is that simple to change.

@duncanmmacleod
pycondor: use 'standard' file extensions
fd71b4e 
- use `.dag` for dag files
- use `.sub` for submit files

Fixes pycondor#134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
PyCondor 0.7.0
Development

Successfully merging this pull request may close these issues.

Use 'standard' file extensions for dag and sub files
3 participants
@duncanmmacleod @GregoryAshton @jodergrosse