Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing order of coordinates in read_cmlh5_file_to_xarray #138

Merged
merged 1 commit into from Oct 25, 2023

Conversation

maxmargraf
Copy link
Contributor

This fix solves #137 by correcting the order of coordinates used to calculate the CML length.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca43839) 74.53% compared to head (8800b25) 74.53%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   74.53%   74.53%           
=======================================
  Files          29       29           
  Lines        1084     1084           
=======================================
  Hits          808      808           
  Misses        276      276           
Flag Coverage Δ
unittests 74.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pycomlink/io/cmlh5_to_xarray.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cchwala cchwala changed the title Fixing order of coordinates Fixing order of coordinates in read_cmlh5_file_to_xarray Oct 25, 2023
@cchwala cchwala self-requested a review October 25, 2023 07:04
Copy link
Contributor

@cchwala cchwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

Luckily, this bug seems to not have impacted other code and the example notebooks since this function which loads the old example CML data is only used (as far as I can see) in the WAA notebook where not rain rates estimates are calculated from this old example data (only from the new example data) and hence the error in length calculation has not effect.

@cchwala cchwala merged commit 86c64a9 into pycomlink:master Oct 25, 2023
5 checks passed
@maxmargraf maxmargraf deleted the correct_order branch October 27, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants