Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WAA notebook #136

Merged
merged 5 commits into from Oct 24, 2023
Merged

Update WAA notebook #136

merged 5 commits into from Oct 24, 2023

Conversation

cchwala
Copy link
Contributor

@cchwala cchwala commented Oct 23, 2023

This PR does

This is required since pycomlink#116

I actually thought I had fixed that during some of the last PRs, but
apparently the problem was still there in this notebook.
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca43839) 74.53% compared to head (1a9973f) 74.53%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #136   +/-   ##
=======================================
  Coverage   74.53%   74.53%           
=======================================
  Files          29       29           
  Lines        1084     1084           
=======================================
  Hits          808      808           
  Misses        276      276           
Flag Coverage Δ
unittests 74.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cchwala cchwala merged commit 014dd68 into pycomlink:master Oct 24, 2023
5 checks passed
maxmargraf added a commit to maxmargraf/pycomlink that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WAA example notebook does not work because of missing pol kwarg
1 participant