change absolute import of pycomlink to relative import #119
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #119 +/- ##
==========================================
+ Coverage 71.62% 71.71% +0.08%
==========================================
Files 28 28
Lines 1008 1011 +3
==========================================
+ Hits 722 725 +3
Misses 286 286
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…_A, also did some minor cleanup of example notebook (pycomlink#116) Things that were done in this PR: * it is now forced to pass `pol` to `calc_R_from_A` when passing `f_GHz`, which is the way we commonly use this function. One can also pass `a` and `b` parameters instead of `f_GHz` and `pol`. There are now also tests that check this behavior. * The WAA function `waa_leijnse_2008_from_A_obs` and `waa_pastorek_2021_from_A_obs` which use `calc_R_from_A` internally, have been adjusted to require a `pol` argument. * Docstrings of the functions have been adjusted and also improved in some parts * tests have been adjusted accordingly and new tests added * black formating in files that were touched in this PR * updated notebook on basic example workflow * use `pol` correctly (which is no enforce anyway, see above) * removed some unnecessary cells * improves some markdown text * changed the way resampling to 5-min and 1-h is done, which we do now after concatenating the list of CML `Datasets` to one large `Dataset` because resampling is much faster like this * made plotting of interpolated maps a bit nicer (in my opinion) * made plotting of time series more consistent (same figure width, removing unnecessary labels, better colors in some places) * use `cml['A'].values[cml.A < 0] = 0` instead of `cml['A'] = cml.A.where(cml.A > 0, 0)`, see pycomlink#117 * added interpolation of short gaps in `trsl`, up to 5 minutes, which improves comparison with reference for high rain rates (I think we had this interpolation in the example notebook some time ago, but maybe it was removed to replace it with the more sophisticated blackout gap filling, which is not there yet..)
…pycomlink into remove_absolute_imports
|
Note that there are some commits, I think from #116, due to merging some older stuff into this branch. I do not want to rebase since I made some mess with stashing locally and am not sure if I might miss something afterwards. Hence, I will just merge now. |
I found at least one absolute import of pycomlink that should be changed to a relative import since it causes problems when using pycomlink as git submodule, i.e. in cases where it is not part of the python env.