Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide traceback for epyccel and lambdify errors #1869

Merged
merged 8 commits into from May 13, 2024
Merged

Conversation

EmilyBourne
Copy link
Member

@EmilyBourne EmilyBourne commented May 8, 2024

Add a try/except around internal pyccel calls to catch all PyccelErrors. This allows the shortest possible traceback to be shown to the user when the error is recognised, handled and reported by Pyccel. Fixes #1868

@EmilyBourne
Copy link
Member Author

EmilyBourne commented May 8, 2024

Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:

  • Write a clear PR description
  • Add tests to check your code works as expected
  • Update documentation if necessary
  • Update Changelog
  • Ensure any relevant issues are linked
  • Ensure new tests are passing

@pyccel-bot
Copy link

pyccel-bot bot commented May 8, 2024

Hello again! Thank you for this new pull request 🤩.

Please begin by requesting your checklist using the command /bot checklist

@EmilyBourne EmilyBourne marked this pull request as ready for review May 8, 2024 16:20
@github-actions github-actions bot marked this pull request as draft May 8, 2024 16:21
@EmilyBourne EmilyBourne marked this pull request as ready for review May 8, 2024 16:22
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot
Copy link

pyccel-bot bot commented May 8, 2024

Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think!

@pyccel-bot pyccel-bot bot requested a review from a team May 8, 2024 16:49
@EmilyBourne EmilyBourne added the next release This PR must be merged before the next release label May 12, 2024
Copy link
Contributor

@mustapha-belbiad mustapha-belbiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me.

@pyccel-bot
Copy link

pyccel-bot bot commented May 13, 2024

Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @mustapha-belbiad think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄

@pyccel-bot pyccel-bot bot added the Ready_for_review Received at least one approval. Requires review from senior developer label May 13, 2024
@EmilyBourne
Copy link
Member Author

/bot run pr_tests

Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot pyccel-bot bot added Ready_for_review Received at least one approval. Requires review from senior developer and removed Ready_for_review Received at least one approval. Requires review from senior developer labels May 13, 2024
@pyccel-bot
Copy link

pyccel-bot bot commented May 13, 2024

Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @mustapha-belbiad think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄

Copy link
Member

@yguclu yguclu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

pyccel/commands/epyccel.py Outdated Show resolved Hide resolved
pyccel/commands/epyccel.py Outdated Show resolved Hide resolved
pyccel/commands/lambdify.py Outdated Show resolved Hide resolved
@github-actions github-actions bot marked this pull request as draft May 13, 2024 12:53
@pyccel-bot pyccel-bot bot removed the Ready_for_review Received at least one approval. Requires review from senior developer label May 13, 2024
@pyccel-bot
Copy link

pyccel-bot bot commented May 13, 2024

@EmilyBourne, @yguclu has a few questions/comments about your code. Can you go through and see if you agree with them. If not go ahead and explain why. Once you've adressed all the comments let me know with /bot mark as ready and we will see if we can get approval.

Co-authored-by: Yaman Güçlü <yaman.guclu@gmail.com>
@EmilyBourne EmilyBourne marked this pull request as ready for review May 13, 2024 13:01
Copy link

@pyccel-bot pyccel-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! Your PR is using all the code it added/changed.

@pyccel-bot pyccel-bot bot added the Ready_for_review Received at least one approval. Requires review from senior developer label May 13, 2024
@pyccel-bot
Copy link

pyccel-bot bot commented May 13, 2024

@yguclu, @EmilyBourne has been working hard and thinks that they have now replied to or fixed all your comments. Could you take another look at the PR and see if you can approve now?

@pyccel-bot pyccel-bot bot requested a review from yguclu May 13, 2024 13:21
@pyccel-bot pyccel-bot bot removed the Ready_for_review Received at least one approval. Requires review from senior developer label May 13, 2024
@pyccel-bot
Copy link

pyccel-bot bot commented May 13, 2024

@yguclu, @EmilyBourne has been working hard and thinks that they have now replied to or fixed all your comments. Could you take another look at the PR and see if you can approve now?

@pyccel-bot pyccel-bot bot added the Ready_for_review Received at least one approval. Requires review from senior developer label May 13, 2024
@pyccel-bot pyccel-bot bot added Ready_to_merge Approved by senior developer. Ready for final approval and merge and removed Ready_for_review Received at least one approval. Requires review from senior developer labels May 13, 2024
@yguclu yguclu merged commit 6f222d9 into devel May 13, 2024
13 checks passed
@yguclu yguclu deleted the devel-issue1868 branch May 13, 2024 13:46
EmilyBourne added a commit that referenced this pull request May 13, 2024
Add a `try/except` around internal Pyccel calls to catch all
`PyccelError`s. This allows the shortest possible traceback to be shown
to the user when the error is recognised, handled and reported by
Pyccel. Fixes #1868.
EmilyBourne added a commit to pyccel/pyccel-cuda that referenced this pull request May 14, 2024
Add a `try/except` around internal Pyccel calls to catch all
`PyccelError`s. This allows the shortest possible traceback to be shown
to the user when the error is recognised, handled and reported by
Pyccel. Fixes pyccel#1868.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next release This PR must be merged before the next release Ready_to_merge Approved by senior developer. Ready for final approval and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide traceback for epyccel errors
3 participants