New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove InhomogeneousTupleVariable #1838
base: devel
Are you sure you want to change the base?
Conversation
Hello again! Thank you for this new pull request 🤩. Please begin by requesting your checklist using the command |
… the creation of specialised _visit functions
Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Your PR is using all the code it added/changed.
/bot run pr_tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Your PR is using all the code it added/changed.
/bot run spelling |
It seems like you have forgotten to complete your checklist for this pull request. Please check the list here, fix the missing items and let me know when everything is ticked and fixed with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Your PR is using all the code it added/changed.
Hey @pyccel/pyccel-dev ! @EmilyBourne has just created this great new pull request! Check it out and let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and the new docs are well written as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ! Your PR is using all the code it added/changed.
Hey @yguclu, @EmilyBourne, this PR is looking pretty good. @EmilyBourne and @Farouk-Echaref think it is ready to merge. Could you add your expertise to confirm that this follows all the coding conventions and fits in Pyccel's future plans? Thanks 😄 |
Remove the
InhomogeneousTupleVariable
class. Fixes #1583 There is now enough information in the types to make this class unnecessary. Removing it allows inhomogeneous tuples to be used in classes (as it was previously not possible to combineDottedVariable
andInhomogeneousTupleVariable
).Commit Summary
symbolic_alias
category in aScope
to map an indexed element of an inhomogeneous tuple to the equivalent variable._build_X
functions for functions which accept inhomogeneous tuple arguments (createdSemanticParser._build_PythonTupleFunction
andSemanticParser._build_NumpyArray
). This allows the variables to be collected from the scope during the building processPyccelUnarySub
to be used as an index (to facilitate indexing with literals)is_literal_integer
function to determine if an expression is a literal integerInhomogeneousTupleVariable
IndexedElement
can handle inhomogeneous tuple objects.FCodePrinter._print_Declare
_visit_Assign
. Fixes COVERAGE : tuples in _visit_Assign Function #1392PythonTuple
at the semantic stage