New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow printing of parameters in Fortran #1811
Draft
EmilyBourne
wants to merge
31
commits into
devel
Choose a base branch
from
devel-issue1807
base: devel
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmilyBourne
added
the
blocked
Cannot be solved/merged until something else is fixed
label
Mar 29, 2024
Hello again! Thank you for this new pull request 🤩. Please begin by requesting your checklist using the command |
EmilyBourne
added a commit
that referenced
this pull request
May 14, 2024
Print unknown constants using their values. This fixes #1047 but may be reverted in #1811 to prefer declaring constants with names. However this PR also adds support for `NaN` in C and an associated test. It also removes the duplicate `_print_Constant` function. --------- Co-authored-by: EmilyBourne <louise.bourne@gmail.com>
EmilyBourne
removed
the
blocked
Cannot be solved/merged until something else is fixed
label
May 14, 2024
EmilyBourne
added a commit
to pyccel/pyccel-cuda
that referenced
this pull request
May 14, 2024
Print unknown constants using their values. This fixes pyccel#1047 but may be reverted in pyccel#1811 to prefer declaring constants with names. However this PR also adds support for `NaN` in C and an associated test. It also removes the duplicate `_print_Constant` function. --------- Co-authored-by: EmilyBourne <louise.bourne@gmail.com>
…efaults to _print_Slice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the printing of constants as
parameter
in Fortran. Use this improvement to avoid unnecessary sign checks when using negative indices.