Correct wrong array order and several bugs returning fortran ordered arrays #1180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @EmilyBourne, what's the status of this PR? |
|
This PR is supposed to fix a memory leak (I think some of the other bug fixes have been fixed in other branches since). It works perfectly for linux and mac but on Windows it is raising "double free". I need someone with a windows machine to run the test with a tool such as drmemory. I haven't been able to find anyone who has a windows machine and would be able to debug this. I managed to install pyccel on a very old Windows machine, but so far I haven't convinced it to run without getting stuck so I haven't been able to test myself. I can "fix" the problem with an |
yguclu
pushed a commit
that referenced
this pull request
Apr 9, 2024
In the Windows installation, do not use the `sleep` command to wait for an executable to finish, as this leads to random crashes. Instead, use the proper Windows commands (taken from PR #1180) to wait for the execution.
EmilyBourne
added a commit
that referenced
this pull request
May 6, 2024
In the Windows installation, do not use the `sleep` command to wait for an executable to finish, as this leads to random crashes. Instead, use the proper Windows commands (taken from PR #1180) to wait for the execution.
EmilyBourne
added a commit
that referenced
this pull request
May 7, 2024
In the Windows installation, do not use the `sleep` command to wait for an executable to finish, as this leads to random crashes. Instead, use the proper Windows commands (taken from PR #1180) to wait for the execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct wrong array order when initialising from a fortran ordered array (fixes #1171). Implemtation of tests showed several bugs when returning fortran ordered arrays. These are also fixed.
Commit Summary
np.arraywhich returns an array and checks flags_ndarray_to_numpy_stridesfunction to return a fortran ordered array