Devel blas #1022
Devel blas #1022
Conversation
| flag_uplo = 'U' | ||
| if lower : flag_uplo = 'L' |
There was a problem hiding this comment.
Why not use an If Ternary operator?
| def blas_drotmg(d1: 'float64', d2: 'float64', x1: 'float64', y1: 'float64', | ||
| param: 'float64[:]'): | ||
|
|
||
| import numpy as np |
There was a problem hiding this comment.
There are lots of unused import numpy as np statements in this file. They should be flagged by codacy when it starts working again
There was a problem hiding this comment.
Have I understood correctly that the aim is for the file tests/epyccel/modules/blas.py to become pyccel/stdlib/external/blas.pyh once PR #1017 is merged? And the file tests/epyccel/test_blas.py would then be rewritten to compile functions which call scipy?
| assert(np.abs(c - expected_c) < 1.e-10) | ||
| assert(np.abs(s - expected_s) < 1.e-10) |
There was a problem hiding this comment.
You can also use np.isclose as in the numpy test files, which takes an absolute and relative tolerance
|
Unfortunately your PR is not passing the tests so it is not quite ready for review yet. Let me know when it is fixed with The failing tests are:
|
|
@rakati I see that you were assigned to this issue in March. Are you working on it at all or should you be removed from the assignees? |
The BLAS wrappers are implemented.
TODO
tests/epyccel/modules/blas.pytopyccel/stdlib/external/blas.py@inlinedecorator (available since Add inline decorator to pyccel #1017 was merged) when header language is not sufficient for mapping the arguments from Fortran to Pythonscipy.linalg.blasandscipy.linalg.lapack