Added: Possibility to specify extension modules. #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@margru thank you for you pull-request, we do appreciate it. Unfortunately, we don't have any resources at the moment to service it so please be patient. |
Adapted: Some integration tests to pass with extension modules parameter.
|
Thanks for the PR! I'm working on a major fix for the PyB with environment isolation and will look at this ASAP afterwards. |
Python sources of cythonized modules can be removed from distribution.
What doesn't make sense? Can you please be more specific? Edit: Sorry, I didn't notice that you are commenting just a specific line in the code. See my comment there... |
Before this, the options provided in the requirements.txt file appear in the install_requires field which then causes errors (e.g. when using cython extensions).
Change default value when ext_modules are empty and update to upstream v0.13.5 and
|
Could you please rebase on current? |
|
@margru ? |
|
@arcivanov Yeah, I will try but I don't have that much time right now to solve the conflicts. I didn't realize that the push will also update the PR... |
Merge upstream to our patched code
Add Cython as a build dependency to setup.py
Add support for cython's compiler_directives
It contains necessary build requirements (currently only Cython if cythonization is required).
(cherry picked from commit 0cc08a8)
It contains necessary build requirements (currently only Cython if cythonization is required). (cherry picked from commit 9565af3)
# Conflicts: # src/main/python/pybuilder/plugins/python/distutils_plugin.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement to fix #639. The extensions might be defined in project's
distutils_ext_modulesproperty as a list of dictionaries where each dictionary represents keyword arguments with values for a singleExtensioninstance constructor. Multiple dictionaries mean multiple extensions to build. The extensions specifications are then rendered into the setup.py script via the template.