Add package_dir option to setup.py

[slitayem]

No description provided.

[AlexeySanko]

Hi, @slitayem
Prefered way to pass arguments to setup function is distutils_... properties, like distutils_setup_keywords, distutils_entry_points or distutils_console_scripts.
Thanks

[AlexeySanko]

I saw a lot of requests for more dynamic setup.py file. What do You think about changing this PR with adding dict property distutils_setup_args which will prodive values directly to setup.py?
And key package_dir with specific value will cover original problem.
Your thoughts?

[arcivanov]

@slitayem I'm sorry, I don't understand the purpose of this. Could you please be a little more verbose about why you want this?

package_dir is used for custom layout of the sources. In PyB you can customize the location of your sources in the tree (defaulting to src/main/python), but in package they'll always be on top even if you customize your layout.

Additionally, in setuptools, find_packages can be used: https://setuptools.readthedocs.io/en/latest/setuptools.html#using-find-packages

What are you trying to achieve and what isn't working for you?

[jtsec92]

Hi, @arcivanov

I understand that in PyB you can customize the location of your sources in the tree (defaulting to src/main/python), but in package they'll always be on top even if you customize your layout.

Is there a simple way to customize the locations of the sources so that they are not always on the top?

Thanks,
J

[arcivanov]

@jtsec92 what do you mean "they are not always on top"?
Could you provide a simple example of what your source tree looks like and what you want to see in the package?

[arcivanov]

Hi, @arcivanov

I understand that in PyB you can customize the location of your sources in the tree (defaulting to src/main/python), but in package they'll always be on top even if you customize your layout.

Is there a simple way to customize the locations of the sources so that they are not always on the top?

Thanks, J

└── src
    ├── __init__.py
    └── main
        ├── python
        │   └── main.py
        └── scripts
            └── test2.sh

You need to move the __init__.py into src/main/python and your main will be where you want it to be. Otherwise the contents of the src/main/python appears as an implicit namespace of "" which you can't have per spec.

[jtsec92]

Thank you,

so should it be:

├── __pycache__
│   └── build.cpython-38.pyc
├── build.py
├── pyproject.toml
├── setup.py
└── src
    └── main
        ├── python
        │   ├── __init__.py
        │   └── main.py
        └── scripts
            └── test2.sh

[jtsec92]

Unfortunately, after running pyb it still ends up at the project root level. I feel like I am missing something obvious.

[arcivanov]

Unfortunately, after running pyb it still ends up at the project root level. I feel like I am missing something obvious.

What is your desired layout IN THE WHEEL package?
I'm confused as to what you're trying to accomplish. Your main.py is at the root of the project, as you specified (src/main/python is the root in your case, so it translates to the root of your dist scratch build).

Your main.py is the root package. It is correctly located as a root package. Where do you think it should be and why does it matter?

[arcivanov]

PS: As a second thought, you don't need the __init__.py at all. You can delete it.

[jtsec92]

I am trying to make the source and target package structure mirror each other. I want the target dist to look like this:

Where main.py is in src/main/python instead of at the project root level.

[jtsec92]

PS: As a second thought, you don't need the __init__.py at all. You can delete it.

Thank you

[arcivanov]

If your target package looks like src/main/python/main.py you will end up having to do import src.python.main.main.
src/main/python is the ROOT of the sources of the packages.

If you REALLY want to do what you're saying just create src/main/python/src/main/python and move your main.py there.